[GPU] Add chained reshape support for scf.forall expand destination pattern #19597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…attern Signed-off-by: Nirvedh Meshram <[email protected]>
|
This is the error that was discovered that this PR fixes |
Max191
reviewed
Jan 7, 2025
compiler/src/iree/compiler/Codegen/Common/PropagateReshapesByExpansion.cpp
Show resolved
Hide resolved
We dont create them, we replace the producer of the reshapes to have the same result type as the reshapes (after doing proper verification) making them trivial, but with wrong (old) reassociations... |
Max191
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when expanding scf.forall we make trivially foldable expand.shape ops (same source and destination ranks) with a wrong reassociation map. However, if there is another expand.shape consumer to these ops then the upstream
ComposeReassociativeReshapeOpscan merge these into a wrong expand.shape op that leads to error. So we just replace the uses of these expand op to avoid this issue.